Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced go:generate with go:embed #738

Merged
merged 6 commits into from
Apr 28, 2021
Merged

Replaced go:generate with go:embed #738

merged 6 commits into from
Apr 28, 2021

Conversation

ersonp
Copy link
Contributor

@ersonp ersonp commented Apr 21, 2021

Did you run make format && make check?

Fixes #737

Changes:

  • replaced //go:generate with //go:embed in skychat

How to test this PR:

  1. Set up Interactive test environments.
  2. git checkout this PR branch.
  3. Follow the instructions to Test with local changes from Interactive test environments.
  4. Run make integration-run-generic
  5. Go to http://localhost:8001/ and http://localhost:8002/ and check if its working as intended.

cmd/apps/skychat/chat.go Outdated Show resolved Hide resolved
@i-hate-nicknames
Copy link
Contributor

Great idea. I would also add a comment where does //go:embed static points to in the project.
Does make format and make check upgrade dependencies? I tried to run those on develop branch and they didn't. Not sure how upgrading packages is related to embedding, can you elaborate please?

@ersonp
Copy link
Contributor Author

ersonp commented Apr 26, 2021

Does make format and make check upgrade dependencies? I tried to run those on develop branch and they didn't. Not sure how upgrading packages is related to embedding, can you elaborate please?

The packages were upgraded because I was having issues with github.com/incu6us/goimports-reviser in make install-linters which installs an older version of goimports-reviser. That has been fixed and merged in developed now. I will revert the upgrades.

@jdknives jdknives merged commit 85973cc into skycoin:develop Apr 28, 2021
@ersonp ersonp deleted the embed-static-asset branch April 11, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants