update german language #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@4rchim3d3s I would stick with
Thanks a lot for this PR. Will check and merge after v0.4.0 is out. |
jdknives
requested changes
Mar 12, 2021
| "error-load": "Beim Aktualisieren der Visor-Liste ist ein Fehler aufgetreten.", | ||
| "empty": "Es ist kein Visor zu diesem Hypervisor verbunden.", | ||
| "empty-with-filter": "Kein Visor erfüllt die gewählten Filterkriterien", |
There was a problem hiding this comment.
Punctuation at the end of the sentence.
There was a problem hiding this comment.
Edited. Should we edit punctuation on all sentences? I think there are a few without at the moment.
| "copied-pk-info": "Öffentlicher Schlüssel wurde kopiert", | ||
| "copy-pk-error": "Beim Kopieren des öffentlichen Schlüssels ist ein Problem aufgetreten.", | ||
| "no-elements": "Derzeit können keine Elemente angezeigt werden. Bitte später versuchen.", | ||
| "no-elements-for-filters": "Keine Elemente, welche die Filterkriterien erfüllen", |
There was a problem hiding this comment.
May need punctuation. Not sure what would be correct since this is not really a sentence, but feels like one. 😄
There was a problem hiding this comment.
Yes, maybe also Keine Elemente vorhanden, ... ?
Senyoret1
approved these changes
Mar 14, 2021
jdknives
approved these changes
Mar 17, 2021
|
Good job. Will merge. @4rchim3d3s @Senyoret1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check?No
Changes:
Questions:
What should be the german word for "Visor"?
-> "der Visor" ?
And what's the plural then?
-> I used "die Visor"
What's prefered: "Update" or "Aktualisierung" ?