Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remote throughput calculation #689

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

Darkren
Copy link
Contributor

@Darkren Darkren commented Feb 23, 2021

Did you run make format && make check?
Yes
Might be part of #688

Changes:

  • Remote throughput previously had a data lag between atomic.LoadValue and atomic.StoreValue. Not very crucial, but under load, calculation might have been a mess. Now this is done with a single atomic call

Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted.

@jdknives jdknives merged commit 36456f8 into skycoin:develop Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants