Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move run command from vpn to osutil, add RunWithResult #685

Closed
wants to merge 4 commits into from
Closed

Move run command from vpn to osutil, add RunWithResult #685

wants to merge 4 commits into from

Conversation

Darkren
Copy link
Contributor

@Darkren Darkren commented Feb 16, 2021

Did you run make format && make check?

Changes:

  • run func was made public and moved to osutil;
  • RunWithResult was added to osutil to run OS command and fetch output reader.

jdknives
jdknives approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@Darkren Darkren mentioned this pull request Mar 12, 2021
Merged
@jdknives
Copy link
Member

Closed as this is superseded by #716

@jdknives jdknives closed this Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-hate-nicknames i-hate-nicknames i-hate-nicknames left review comments

@jdknives jdknives jdknives approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Darkren @jdknives @i-hate-nicknames