Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timeouts for proxy client #65

Merged
merged 2 commits into from
Nov 12, 2019
Merged

Fix timeouts for proxy client #65

merged 2 commits into from
Nov 12, 2019

Conversation

nkryuchkov
Copy link
Contributor

Part of https://github.com/SkycoinPro/skywire-services/issues/25

Changes:

  • Adjust timeouts to make e2e tests pass.
  • Minor timeout fixes.

How to test this PR:
Run e2e-tests in https://github.com/SkycoinPro/skywire-services

evanlinjin
evanlinjin approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

internal/therealproxy/client.go Outdated Show resolved Hide resolved
@nkryuchkov nkryuchkov merged commit 503dd8d into skycoin:master Nov 12, 2019
@nkryuchkov nkryuchkov deleted the fix/proxy-timeouts branch March 13, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanlinjin evanlinjin evanlinjin approved these changes

@Darkren Darkren Awaiting requested review from Darkren

@jdknives jdknives Awaiting requested review from jdknives

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkryuchkov @evanlinjin