static compilation w/musl #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rministic builds ; update documentation about musl ; update documentation about hypervisor & visor configuration ; remove dPKGBUILD.sh and associated makefile entries as I am not maintaining this method for building packages.
jdknives
requested changes
Dec 15, 2020
There was a problem hiding this comment.
This means we cannot build on Mac anymore. I tried setting up musl on Mac and it is not as straightforward as I hoped. Also it does not come with most distributions by default so users could not build straight away on those systems if they wanted. Will check with @SkycoinSynth about whether he still wants us to go ahead with this nonetheless.
…ault ; small change in documentation to reflect this.
Fix makefile static compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static compilation with musl per haltingstate's reuest
I couldn't figure out how to escape the quotation marks in the makefile so i just eliminated that env and put it inline in the go build command.
Also, for deterministic builds you really want to be in the directory where you're building the .go file into a binary so that the path isn't written into the binary.
Did you run
make format && make check?no changes to go source were made
Fixes #
#614
Changes:
How to test this PR:
make buildAdditional context:
My current debian build uses dependencies only available on archlinux but it works much better than that script. As I am actively developing .deb packages in https://github.com/the-skycoin-project/deb I have no intention of maintaining the more rudimentary method which avoids the arch deps.