Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong use of middleware context in hypervisor. #63

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Fix wrong use of middleware context in hypervisor. #63

merged 1 commit into from
Nov 11, 2019

Conversation

evanlinjin
Copy link
Contributor

Fixes #58

Changes:

  • Fix wrong use of middleware context in hypervisor.

@nkryuchkov nkryuchkov merged commit 8e2bb22 into skycoin:master Nov 11, 2019
@Senyoret1
Copy link
Contributor

@evanlinjin This appears to be working well, I was able to remove transports without issues. However, there is a problem with the routes: until now I have been removing the routes by calling DELETE /api/nodes/{pk}/routes/{routeId} sending as the routeId param the value named key returned by the GET /api/nodes/{pk}/routes API endpoint, but that appears to not be working anymore. When I do that, the DELETE /api/nodes/{pk}/routes/{routeId} API endpoint returns {"error":"invalid UUID length: 0"}, so I think it is now expecting a different value, the problem is that I don't know were to get that value from, as the GET /api/nodes/{pk}/routes API endpoint does not return it, or at least not in a evident way.

Maybe a new issue should be filed for this problem, but I don't know what the sollution should be, if adding the param to the GET /api/nodes/{pk}/routes API endpoint, or making the DELETE /api/nodes/{pk}/routes/{routeId} acept the key param returned by GET /api/nodes/{pk}/routes, or something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It is not possible to delete transports and routes using the hypervisor API
3 participants