Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix refreshing of state of the app. #615

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Fix refreshing of state of the app. #615

merged 1 commit into from
Nov 27, 2020

Conversation

taras-skycoin
Copy link
Member

Did you run make format && make check?

Fixes #571

Changes:

  • Add an extended check for the status of the app.

How to test this PR:

  1. Start VPN-client
  2. Check the state of the app on the page of the visor
  3. Kill the process of the app
  4. Check if the status on-page of the app changed after some delay.

@taras-skycoin taras-skycoin changed the title Fix refreshing of state of app. Fix refreshing of state of the app. Nov 23, 2020
jdknives
jdknives approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works smoothly. Well done.

Darkren
Darkren approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@Darkren Darkren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@i-hate-nicknames
Copy link
Contributor

Is this a vpn specific issue? Works locally for skychat

@jdknives
Copy link
Member

@i-hate-nicknames we only saw this issue with VPN so far.

@jdknives jdknives merged commit 2407bb5 into skycoin:develop Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darkren Darkren Darkren approved these changes

@jdknives jdknives jdknives approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@taras-skycoin @i-hate-nicknames @jdknives @Darkren