Make VPN work properly over stcpr #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darkren
changed the title
jdknives
approved these changes
Sep 16, 2020
nkryuchkov
approved these changes
Sep 16, 2020
| BeforeDialCallback: func(network, addr string) error { | ||
| data := appevent.TCPDialData{RemoteNet: network, RemoteAddr: addr} | ||
| event := appevent.NewEvent(appevent.TCPDial, data) | ||
| _ = eb.Broadcast(context.Background(), event) //nolint:errcheck |
There was a problem hiding this comment.
Could you please explain why an error is ignored here instead of returning?
There was a problem hiding this comment.
@nkryuchkov dial will be cancelled in case of error, cause callback is fired before dialing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check?Yes
Fixes #517, partially implements #383
Changes:
How to test this PR:
Setup VPN connection over STCPR transport