Add password options to the UI of the proxy and vpn client apps #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's no password setting for I've implemented removing args if their passed value is empty: #522 |
nkryuchkov
suggested changes
Sep 15, 2020
| * Makes the app use the data from a history entry. | ||
| * @param entry Entry to be used. | ||
| */ | ||
| useFronHistory(entry: HistoryEntry) { |
There was a problem hiding this comment.
Did you mean useFromHistory?
| "password-dialog": { | ||
| "title": "Enter Password", | ||
| "password": "Password", | ||
| "info": "You are being asked for a password because a a password was set when the selected entry was created, but the it was not saved for security reasons. You can leave the password empty if needed.", |
There was a problem hiding this comment.
It seems there's a redundant a in because a a password was set when the selected entry was created
| "password-dialog": { | ||
| "title": "Enter Password", | ||
| "password": "Password", | ||
| "info": "You are being asked for a password because a a password was set when the selected entry was created, but the it was not saved for security reasons. You can leave the password empty if needed.", |
|
@nkryuchkov Thanks for the code review. I removed the password field for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check?The go code was not changed.
npm run lintandnpm run buildwere used.Fixes #519
Changes:
vpn-clientandskysocks-clientapps.How to test this PR:
Using the manager open the app configuration modal window for the
vpn-clientandskysocks-clientapps. You will be able to enter a password manually.NOTE: the changes in this PR don’t work totally well because of 2 things:
When changing the password of the
skysocks-clientapp, the server returnsApp skysocks-client is not allowed to change passwordas error. For the PR work well, the backend has to be changed to avoid that error. The password field could be removed when changing the configuration of theskysocks-clientapp, to avoid the problem, but that does not appear to be a good solution, as it is possible to set a password for theskysocksapp, so the situation would be similar to Missing frontend support for setting VPN client passcode arg #519The hypervisor API does not allow to remove the
-passcodesetting. Because of that, if the user does not enter a password the manager sends an empty string to the backend as the password, so the app configuration will have an empty string as password. If that solution is ok, then there is no problem with this point.