Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Route encryption #444

Merged
merged 13 commits into from
Aug 7, 2020
Merged

Route encryption #444

merged 13 commits into from
Aug 7, 2020

Conversation

Darkren
Copy link
Contributor

@Darkren Darkren commented Jul 17, 2020

Did you run make format && make check?
Not yet
Fixes #432

Changes:

  • Data packets are E2E encrypted between communicating visors

@Darkren Darkren changed the title [WIP] Route encryption Route encryption Jul 17, 2020
nkryuchkov
nkryuchkov suggested changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@nkryuchkov nkryuchkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Just minor requests

pkg/router/router.go Outdated Show resolved Hide resolved
pkg/router/router.go Outdated Show resolved Hide resolved
pkg/router/router.go Outdated Show resolved Hide resolved
pkg/router/router_test.go Outdated Show resolved Hide resolved
@jdknives
Copy link
Member

@Darkren do you want to do that in a separate PR or should we remove encryption logic from VPN apps?

evanlinjin
evanlinjin suggested changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Tested it with local env.

Please also ensure make check passes.

pkg/router/router.go Show resolved Hide resolved
pkg/router/router.go Outdated Show resolved Hide resolved
pkg/router/router_test.go Outdated Show resolved Hide resolved
pkg/router/router_test.go Show resolved Hide resolved
@Darkren
Copy link
Contributor Author

Darkren commented Jul 29, 2020

@Darkren do you want to do that in a separate PR or should we remove encryption logic from VPN apps?

@jdknives I'll do it here. Sorry, just forgot about this

@jdknives jdknives merged commit 794e80a into skycoin:develop Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanlinjin evanlinjin evanlinjin requested changes

@nkryuchkov nkryuchkov nkryuchkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Darkren @jdknives @evanlinjin @nkryuchkov