Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Health checks for services #426

Merged
merged 8 commits into from
Jul 2, 2020
Merged

Health checks for services #426

merged 8 commits into from
Jul 2, 2020

Conversation

nkryuchkov
Copy link
Contributor

@nkryuchkov nkryuchkov commented Jul 1, 2020 •
edited
Loading

Did you run make format && make check? Yes

Fixes #422

Changes:

  • Health checks for services
  • One address resolver client for all transports
  • Add uptime tracker and address resolver statuses to frontend

How to test this PR:

  • Run generic env
  • Go to the hypervisor UI
  • Check if transport discovery, route finder, setup node are up and if uptime tracker, address resolver are up/down depending on the config

@nkryuchkov nkryuchkov marked this pull request as ready for review July 1, 2020 13:41
@nkryuchkov
Merge branch 'develop' into feature/health-check
06e91ea 
# Conflicts:
#	internal/vpn/client.go
#	internal/vpn/env.go
#	pkg/snet/arclient/client.go
#	pkg/snet/arclient/mock_api_client.go
#	pkg/snet/network.go
#	pkg/snet/snettest/env.go
#	pkg/visor/init.go
#	pkg/visor/visorconfig/config.go
#	pkg/visor/visorconfig/v1.go
@nkryuchkov
Fix issues after merging
b79f20c
@nkryuchkov
Allow visor to start in case of address resolver failure
4a7ad7d
@nkryuchkov
Fix tests
7a3ea0e
@nkryuchkov nkryuchkov merged commit 78b18d1 into skycoin:develop Jul 2, 2020
@nkryuchkov nkryuchkov deleted the feature/health-check branch July 2, 2020 15:53
jdknives pushed a commit that referenced this pull request Oct 19, 2020
@nkryuchkov
Merge pull request #426 from nkryuchkov/feature/health-check
3d7621c 
Health checks for services

Former-commit-id: 78b18d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanlinjin evanlinjin evanlinjin approved these changes

@Darkren Darkren Awaiting requested review from Darkren

@jdknives jdknives Awaiting requested review from jdknives

@Senyoret1 Senyoret1 Awaiting requested review from Senyoret1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkryuchkov @evanlinjin