Implement a UDP transport #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # go.mod # go.sum # pkg/snet/network.go # pkg/snet/snettest/env.go # vendor/modules.txt
Darkren
reviewed
Jun 10, 2020
| } | ||
|
|
||
| if lAddr, rAddr, err = origin(conn, deadline); err != nil { | ||
| err = HandshakeError(err.Error()) |
There was a problem hiding this comment.
@Darkren I guess we should. I copied it from stcp with no changes. @evanlinjin What do you think about it?
| } | ||
|
|
||
| hash := cipher.SumSHA256(b.Bytes()) | ||
| rPK, err := cipher2.PubKeyFromSig(cipher2.Sig(sig), cipher2.SHA256(hash)) |
There was a problem hiding this comment.
shouldn't we handle this error?
There was a problem hiding this comment.
Same here, just copied. I'm not sure. @evanlinjin What do you think?
jdknives
pushed a commit
that referenced
this pull request
Oct 19, 2020
Implement a UDP transport Former-commit-id: 45f4526
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check? YesFixes #391
Changes:
How to test this PR:
skywire-servicesagainstfeature/sudpmake integration-startup-sudpcurl --data {'"recipient":"'$PK_A'", "message":"Hello"}' -X POST $CHAT_CVisorAlogs