Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up formatting imports using goimports-reviser #384

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Set up formatting imports using goimports-reviser #384

merged 1 commit into from
Jun 2, 2020

Conversation

nkryuchkov
Copy link
Contributor

@nkryuchkov nkryuchkov commented Jun 1, 2020 •
edited
Loading

Did you run make format && make check? Yes

Partially fixes #361

Changes:

  • Set up formatting imports using github.com/incu6us/goimports-reviser in the format Makefile target.
  • Add installation of github.com/incu6us/goimports-reviser to the install-linters Makefile target.

@jdknives jdknives merged commit 240adb2 into skycoin:develop Jun 2, 2020
@nkryuchkov nkryuchkov deleted the feature/format-imports branch June 2, 2020 09:45
jdknives added a commit that referenced this pull request Oct 19, 2020
@jdknives
Merge pull request #384 from nkryuchkov/feature/format-imports
b2577ce 
Set up formatting imports using goimports-reviser

Former-commit-id: 240adb2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanlinjin evanlinjin evanlinjin approved these changes

@Darkren Darkren Awaiting requested review from Darkren

@jdknives jdknives Awaiting requested review from jdknives

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkryuchkov @evanlinjin @jdknives