Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating improvements #380

Merged
merged 37 commits into from
Jun 11, 2020

Conversation

nkryuchkov
Copy link
Contributor

@nkryuchkov nkryuchkov commented May 30, 2020

Did you run make format && make check? Yes

Fixes #372, fixes #350, fixes skycoin/skybian#31

After merging, https://github.com/SkycoinProject/skywire-mainnet/releases/tag/v0.2.4-test-b7cfc168 should be removed.

Changes:

  • Specify URL to download from
  • Specify stable/beta target
  • Update hypervisor itself
  • Accept both --config and no --config for skywire-visor config (otherwise, updating from older versions would be broken)
  • Fix buildinfo path
  • Update VPN apps
  • Fix updating if a release contains new apps
  • Fix updating algorithm when supervised by systemd
  • Skip updating binary if it is not found in an update

How to test this PR:

  1. Checkout skywire-services against feature/holepunch-server branch
  2. Run generic integration env
  3. Send different curl requests based on this one:
curl -k -d '{"checksums_url":"", "archive_url":"", "channel":"", "version":""}' -X POST https://localhost:8000/api/visors/024ec47420176680816e0406250e7156465e4531f5b26057c9f6297bb0303558c7/update

Possible values:

  • empty/no values do not modify the behavior; all empty values set default updater behavior
  • channel sets updating channel; stable is the latest release, testing is the latest pre-release; stable is default
  • version is a git version; overrides channel
  • checksums_url and archive_url set links for downloading directly; they override version and channel
  1. Send these curl requests:
curl -k -X GET https://localhost:8000/api/visors/024ec47420176680816e0406250e7156465e4531f5b26057c9f6297bb0303558c7/update/available
curl -k -X GET https://localhost:8000/api/visors/024ec47420176680816e0406250e7156465e4531f5b26057c9f6297bb0303558c7/update/available/stable
curl -k -X GET https://localhost:8000/api/visors/024ec47420176680816e0406250e7156465e4531f5b26057c9f6297bb0303558c7/update/available/testing

@nkryuchkov nkryuchkov requested review from evanlinjin, Darkren and jdknives and removed request for evanlinjin and Darkren May 30, 2020 22:10
@nkryuchkov nkryuchkov marked this pull request as ready for review May 30, 2020 22:13
Copy link
Contributor

@Darkren Darkren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Copy link
Contributor

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I'll give it a test.

@nkryuchkov nkryuchkov force-pushed the feature/updater-improvements branch from ccd9f8d to dccc0a2 Compare June 4, 2020 19:34
@nkryuchkov nkryuchkov force-pushed the feature/updater-improvements branch from f3f668c to 4bacd5e Compare June 5, 2020 08:06
@nkryuchkov nkryuchkov merged commit 48a25b9 into skycoin:develop Jun 11, 2020
@nkryuchkov nkryuchkov deleted the feature/updater-improvements branch June 11, 2020 10:56
jdknives pushed a commit that referenced this pull request Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating improvements Visor doesn't show up in hypervisor UI after binary update
3 participants