-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating improvements #380
Merged
nkryuchkov
merged 37 commits into
skycoin:develop
from
nkryuchkov:feature/updater-improvements
Jun 11, 2020
Merged
Updating improvements #380
nkryuchkov
merged 37 commits into
skycoin:develop
from
nkryuchkov:feature/updater-improvements
Jun 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkryuchkov
requested review from
evanlinjin,
Darkren and
jdknives
and removed request for
evanlinjin and
Darkren
May 30, 2020 22:10
This was
linked to
issues
Jun 2, 2020
Closed
…' into feature/updater-improvements
Darkren
approved these changes
Jun 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
evanlinjin
reviewed
Jun 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. I'll give it a test.
nkryuchkov
force-pushed
the
feature/updater-improvements
branch
from
June 4, 2020 19:34
ccd9f8d
to
dccc0a2
Compare
nkryuchkov
force-pushed
the
feature/updater-improvements
branch
from
June 5, 2020 08:06
f3f668c
to
4bacd5e
Compare
This was referenced Jun 11, 2020
Closed
jdknives
pushed a commit
that referenced
this pull request
Oct 19, 2020
Updating improvements Former-commit-id: 48a25b9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check
? YesFixes #372, fixes #350, fixes skycoin/skybian#31
After merging, https://github.com/SkycoinProject/skywire-mainnet/releases/tag/v0.2.4-test-b7cfc168 should be removed.
Changes:
--config
and no--config
forskywire-visor
config (otherwise, updating from older versions would be broken)buildinfo
pathsystemd
How to test this PR:
skywire-services
againstfeature/holepunch-server
branchcurl
requests based on this one:curl -k -d '{"checksums_url":"", "archive_url":"", "channel":"", "version":""}' -X POST https://localhost:8000/api/visors/024ec47420176680816e0406250e7156465e4531f5b26057c9f6297bb0303558c7/update
Possible values:
channel
sets updating channel;stable
is the latest release,testing
is the latestpre-release
;stable
is defaultversion
is agit
version; overrideschannel
checksums_url
andarchive_url
set links for downloading directly; they overrideversion
andchannel
curl
requests: