Appevent module implementation. #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanlinjin
force-pushed
the
feature/app-rpc-interface
branch
from
1652a8a
to
d21c1d0
Compare
evanlinjin
changed the title
evanlinjin
force-pushed
the
feature/app-rpc-interface
branch
from
a24178b
to
ee42b0c
Compare
evanlinjin
changed the title
The appevent module allows for events to be broadcasted from visor (via appserver) to apps. Events have an event type what determines the contents of the event data. Apps subscribe to chosen event types, which are broadcasted via event channels (one event channel per event type). * Introduced a new optional line of communication between app/visor for event broadcast, in which app hosts the listener and the visor (via appserver) does the dial. The app advertises this optional listening address (if it exists) to the visor via the main app <-> visor connection. * Apps now use the appcommon.Hello JSON object as their initial dial message to appserver (this contains the proc_key, and event broadcast connection related fields). * app.NewClient() now has an optional appevent.Subscriber as input. If defined, the broadcast event connection will be created and the appevent.Subscriber object will be used for receiving events. * Updated dmsg version to make use of callbacks (for dialing and closing sessions). Other changes: * Updated golangci-lint version for travis. * Updated helloworld app to listen/write in a loop and to log all events comming from appserver.
evanlinjin
force-pushed
the
feature/app-rpc-interface
branch
from
ee42b0c
to
252e30c
Compare
Darkren
suggested changes
May 25, 2020
* Remove various empty lines and fix typos. * Remove unnecessary chan close in appevent.Broadcaster. * Make multiple calls to .OnTCPDial and .OnTCPClose safe for appevent.Subscriber
jdknives
pushed a commit
that referenced
this pull request
Oct 19, 2020
Appevent module implementation. Former-commit-id: edac199
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #370
The appevent module allows for events to be broadcasted from visor (via appserver) to apps.
Events have an event type what determines the contents of the event data.
Apps subscribe to chosen event types, which are broadcasted via event channels (one event channel per event type).
Other changes:
Testing instructions
helloworldapp.