-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package directive to Makefile #366
Conversation
Can someone please review this pull request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the package and it works well. Good job. This will not be merged yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. Please review my comments.
Good to go, pending your approval. |
@evanlinjin please review this again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for these minor issues, this works great! Good job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Good job!
@evanlinjin many thanks for your approval and support @jdknives when can this be merged? i would update the README.md about this but i dont want to delay the merge at this point. |
Will merge this now. @0pcom good job. |
…sums.txt during build. Former-commit-id: 82e2336
Add package directive to Makefile Former-commit-id: b685c15
…d hypervisor
Did you run
make format && make check
?No changes to the source were made outside the Makefile except adding systemd services. Possibly unnecessary for me to do that.
Partial fix for #387
Changes:
How to test this PR:
Create packages for amd64, arm64, and armhf:
(use root so permissions are correct)
install the correct package for your architecture (assuming you use amd64 debian):
if you have configuration files in place at
/etc/skywire-viosor.json
or/etc/skywire-hypervisor.json
, start the systemd service(s) of your choice and verify it's functionality