Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package directive to Makefile #366

Merged
merged 13 commits into from
Jun 15, 2020
Merged

Add package directive to Makefile #366

merged 13 commits into from
Jun 15, 2020

Conversation

0pcom
Copy link
Collaborator

@0pcom 0pcom commented May 19, 2020

…d hypervisor

Did you run make format && make check?
No changes to the source were made outside the Makefile except adding systemd services. Possibly unnecessary for me to do that.

Partial fix for #387

Changes:

  • Add package directives to the Makefile for building amd64, arm64, and armhf .deb packages

How to test this PR:

Create packages for amd64, arm64, and armhf:
(use root so permissions are correct)

sudo make all-packages

install the correct package for your architecture (assuming you use amd64 debian):

sudo dpkg -i *amd64.deb

if you have configuration files in place at /etc/skywire-viosor.json or /etc/skywire-hypervisor.json, start the systemd service(s) of your choice and verify it's functionality

sudo systemctl start skywire-visor
sudo systemctl start skywire-hypervisor

@0pcom
Copy link
Collaborator Author

0pcom commented May 27, 2020

Can someone please review this pull request?

Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the package and it works well. Good job. This will not be merged yet.

Copy link
Contributor

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Please review my comments.

Makefile Outdated Show resolved Hide resolved
static/skywire-hypervisor.service Outdated Show resolved Hide resolved
@0pcom
Copy link
Collaborator Author

0pcom commented Jun 3, 2020

Good to go, pending your approval.

@jdknives
Copy link
Member

jdknives commented Jun 7, 2020

@evanlinjin please review this again

Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for these minor issues, this works great! Good job.

scripts/dPKGBUILD.sh Outdated Show resolved Hide resolved
@0pcom 0pcom requested a review from evanlinjin June 12, 2020 22:22
Copy link
Contributor

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Good job!

@0pcom
Copy link
Collaborator Author

0pcom commented Jun 15, 2020

@evanlinjin many thanks for your approval and support

@jdknives when can this be merged?

i would update the README.md about this but i dont want to delay the merge at this point.

@jdknives
Copy link
Member

@evanlinjin many thanks for your approval and support

@jdknives when can this be merged?

i would update the README.md about this but i dont want to delay the merge at this point.

Will merge this now. @0pcom good job.

@jdknives jdknives merged commit b685c15 into skycoin:develop Jun 15, 2020
jdknives pushed a commit that referenced this pull request Oct 19, 2020
jdknives added a commit that referenced this pull request Oct 19, 2020
Add package directive to Makefile

Former-commit-id: b685c15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants