Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Versioned visor configs. #364

Merged
merged 13 commits into from
May 21, 2020
Merged

Versioned visor configs. #364

merged 13 commits into from
May 21, 2020

Conversation

evanlinjin
Copy link
Contributor

@evanlinjin evanlinjin commented May 17, 2020 •
edited
Loading

Fixes #362 Fixes #365

Changes:

  • Moved visor conifg-related parts to a new module /pkg/visor/visorconfig.
  • Introduced visorconfig.Common that contains shared fields across all config versions.
  • Improved config-parsing logic.

To do:

  • Visor shutdown order should be inverted.
  • Implement default testenv config generation.
  • Implement config upgrading from v0.0.0.
  • Fix CLI: https://discordapp.com/channels/466450852098605059/466450852098605061/711893952856457237 
    $ ./skywire-cli visor add-tp 0219bec686b86f828bd1995d6c5c8587aa6d55a3f1ae88951eda0890ca456e4d08 --type dmsg
[2020-05-18T13:46:12+03:00] FATAL [skywire-cli]: Failed to establish dmsg transport error="rpc client timeout"
  • Write tests.
  • Add pk back into visor config.
  • Make all package loggers respect master logger settings.

How to test this PR:

  • make check
  • skywire-cli visor gen-config (test with different combinations of flags)
  • skywire-visor with an older config version (e.g. from master branch)

@evanlinjin
Initial work on versioned visor configs.
345bfb1 
* Moved visor conifg-related parts to a new module /pkg/visor/visorconfig.
* Introduced visorconfig.Common that contains shared fields across all config versions.
* Improved config-parsing logic.
@evanlinjin evanlinjin added the enhancement New feature or request label May 17, 2020
This was linked to issues May 18, 2020
Properly implement versioned visor config. #362
Closed
Get back -t flag for skywire-cli visor gen-config #365
Closed
@evanlinjin evanlinjin marked this pull request as ready for review May 18, 2020 23:09
@evanlinjin evanlinjin changed the title WIP: Versioned visor configs. Versioned visor configs. May 18, 2020
nkryuchkov
nkryuchkov reviewed May 19, 2020
View reviewed changes
ci_scripts/install-golangci-lint.sh Outdated Show resolved Hide resolved
cmd/skywire-cli/commands/visor/gen-config.go Show resolved Hide resolved
cmd/skywire-visor/commands/root.go Outdated Show resolved Hide resolved
cmd/skywire-visor/commands/root.go Outdated Show resolved Hide resolved
cmd/skywire-visor/commands/root.go Outdated Show resolved Hide resolved
pkg/visor/init.go Outdated Show resolved Hide resolved
pkg/visor/rpc_test.go Show resolved Hide resolved
pkg/visor/visor.go Show resolved Hide resolved
pkg/visor/visorconfig/common.go Outdated Show resolved Hide resolved
@evanlinjin evanlinjin marked this pull request as draft May 19, 2020 12:57
@evanlinjin evanlinjin marked this pull request as ready for review May 20, 2020 07:28
Darkren
Darkren suggested changes May 20, 2020
View reviewed changes
Copy link
Contributor

@Darkren Darkren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, great job? Also, could you please run latest readmegen to generate readme for new config?

pkg/visor/visorconfig/parse_test.go Outdated Show resolved Hide resolved
@jdknives jdknives merged commit 1505b8b into develop May 21, 2020
@jdknives jdknives deleted the feature/versioned-config-#362 branch June 15, 2020 17:36
jdknives added a commit that referenced this pull request Oct 19, 2020
@jdknives
Merge pull request #364 from SkycoinProject/feature/versioned-config-…
92b4461 
…#362

Versioned visor configs.

Former-commit-id: 1505b8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkryuchkov nkryuchkov nkryuchkov left review comments

@Darkren Darkren Darkren requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get back -t flag for skywire-cli visor gen-config Properly implement versioned visor config.
4 participants
@evanlinjin @Darkren @nkryuchkov @jdknives