Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy discovery. #340

Merged
merged 8 commits into from
Apr 29, 2020
Merged

Proxy discovery. #340

merged 8 commits into from
Apr 29, 2020

Conversation

evanlinjin
Copy link
Contributor

No description provided.

@evanlinjin evanlinjin changed the title [WIP] Proxy discovery. WIP: Proxy discovery. Apr 21, 2020
@evanlinjin evanlinjin changed the base branch from master to develop April 21, 2020 05:53
志宇 added 5 commits April 21, 2020 17:54
Merge remote-tracking branch 'origin/develop' into feature/proxy-disc…
b2772c8 
…overy
Fix panic.
60e825c
Proxy discovery client fixes.
2683e7c 
* skysocks instance no longer updates discovery entry if passcode is set.

* Ensure skywire port of skysocks is submitted when updating.
Ensure proxy discovery client re-updates geo info after every update.
231ac73
Improve log appearance.
f433987
@evanlinjin evanlinjin marked this pull request as ready for review April 27, 2020 07:21
@evanlinjin evanlinjin changed the title WIP: Proxy discovery. Proxy discovery. Apr 27, 2020
Darkren
Darkren suggested changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@Darkren Darkren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great job! Just few small queries. Also, mock_proc_manager shouldn't be removed as it'll be generated with the old name once we do make generate. And it also seems more conventional to me

pkg/app/appdisc/discovery_updater.go Outdated Show resolved Hide resolved
pkg/app/appdisc/factory.go

// Factory creates appdisc.Updater instances based on the app name.
type Factory struct {
Log logrus.FieldLogger
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these fields be unexported for safety?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thoughts are that appdisc.Factory acts as a config or sorts that generates discovery updaters. These fields are only read for generating such discovery updaters.

Hope that is okay?

nkryuchkov
nkryuchkov reviewed Apr 27, 2020
View reviewed changes
Makefile Outdated Show resolved Hide resolved
pkg/app/appdisc/factory.go Outdated Show resolved Hide resolved
pkg/app/appserver/proc.go Outdated Show resolved Hide resolved
pkg/app/appserver/proc_manager.go Outdated Show resolved Hide resolved
pkg/app/appserver/server.go Outdated Show resolved Hide resolved
pkg/proxydisc/client.go Outdated Show resolved Hide resolved
@evanlinjin evanlinjin merged commit 1dec436 into develop Apr 29, 2020
@jdknives jdknives mentioned this pull request Apr 29, 2020
Closed
@jdknives jdknives mentioned this pull request May 19, 2020
Closed
@jdknives jdknives deleted the feature/proxy-discovery branch June 15, 2020 17:35
jdknives pushed a commit that referenced this pull request Oct 19, 2020
Merge pull request #340 from SkycoinProject/feature/proxy-discovery
dc48d07 
Proxy discovery.

Former-commit-id: 1dec436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkryuchkov nkryuchkov nkryuchkov left review comments

@Darkren Darkren Darkren requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evanlinjin @Darkren @nkryuchkov