Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy discovery client. #318

Merged
merged 4 commits into from
Apr 14, 2020
Merged

Proxy discovery client. #318

merged 4 commits into from
Apr 14, 2020

Conversation

evanlinjin
Copy link
Contributor

No description provided.

@evanlinjin evanlinjin changed the title Proxy discovery client. [WIP] Proxy discovery client. Apr 13, 2020
@evanlinjin evanlinjin changed the title [WIP] Proxy discovery client. Proxy discovery client. Apr 13, 2020
Copy link
Contributor

@Darkren Darkren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

pkg/proxydisc/client.go Outdated Show resolved Hide resolved
Copy link
Contributor

@nkryuchkov nkryuchkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine, great job!

pkg/proxydisc/error.go Outdated Show resolved Hide resolved
@evanlinjin evanlinjin merged commit a071c45 into develop Apr 14, 2020
@jdknives jdknives deleted the feature/proxy-discovery branch April 14, 2020 09:00
jdknives pushed a commit that referenced this pull request Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants