-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use default values if required visor config fields are empty #246
Merged
jdknives
merged 10 commits into
skycoin:develop
from
nkryuchkov:feature/fill-config-defaults
Mar 25, 2020
Merged
Use default values if required visor config fields are empty #246
jdknives
merged 10 commits into
skycoin:develop
from
nkryuchkov:feature/fill-config-defaults
Mar 25, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # cmd/skywire-cli/commands/visor/gen-config.go # cmd/skywire-visor/commands/root.go # pkg/visor/config.go # pkg/visor/rpc_test.go # pkg/visor/visor.go # pkg/visor/visor_test.go
nkryuchkov
requested review from
Darkren,
jdknives and
evanlinjin
and removed request for
Darkren and
jdknives
March 24, 2020 19:11
evanlinjin
approved these changes
Mar 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work.
Darkren
approved these changes
Mar 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Just a small question in there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check
? YesFixes #168
Depends on https://github.com/SkycoinPro/skywire-services/pull/127
Changes:
How to test this PR:
make test
INFO []: Starting visor PK=
with generated PKs instead of empty PKs. Restart integration env and check if generated PKs changed.skywire-cli
:./skywire-cli visor gen-config -o ./test.json -r -m WD
./skywire-cli visor gen-config -o ./test.json -r -m HOME
./skywire-cli visor gen-config -o ./test.json -r -m LOCAL