Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default values if required visor config fields are empty #246

Merged
merged 10 commits into from
Mar 25, 2020
Merged

Use default values if required visor config fields are empty #246

merged 10 commits into from
Mar 25, 2020

Conversation

nkryuchkov
Copy link
Contributor

@nkryuchkov nkryuchkov commented Mar 24, 2020 •
edited
Loading

Did you run make format && make check? Yes

Fixes #168
Depends on https://github.com/SkycoinPro/skywire-services/pull/127

Changes:

  • Use default values if required visor config fields are empty
  • Cleanup visor config and related configs

How to test this PR:

  • make test
  • Run integration env, then check if nothing is broken
  • Remove visor keys from integration env configs, run integration env. Scripts for checking communication should be broken. Visor logs should contain messages INFO []: Starting visor PK= with generated PKs instead of empty PKs. Restart integration env and check if generated PKs changed.
  • Generate configs with skywire-cli:
    • ./skywire-cli visor gen-config -o ./test.json -r -m WD
    • ./skywire-cli visor gen-config -o ./test.json -r -m HOME
    • ./skywire-cli visor gen-config -o ./test.json -r -m LOCAL

@nkryuchkov nkryuchkov linked an issue Mar 24, 2020 that may be closed by this pull request
Config migration on binaries update #168
Closed
@nkryuchkov nkryuchkov mentioned this pull request Mar 24, 2020
Closed
@nkryuchkov
Fix default config generation
9fe29e7
@nkryuchkov
Merge branch 'develop' into feature/fill-config-defaults
e2eaeea 
# Conflicts:
#	cmd/skywire-cli/commands/visor/gen-config.go
#	cmd/skywire-visor/commands/root.go
#	pkg/visor/config.go
#	pkg/visor/rpc_test.go
#	pkg/visor/visor.go
#	pkg/visor/visor_test.go
@nkryuchkov
Fix errors after merging
733077e
@nkryuchkov
Return Version to Visor config
44de409
@nkryuchkov
Output PK in Visor logs
61a26f2
@nkryuchkov nkryuchkov marked this pull request as ready for review March 24, 2020 19:11
@nkryuchkov nkryuchkov requested review from Darkren, jdknives and evanlinjin and removed request for Darkren and jdknives March 24, 2020 19:11
evanlinjin
evanlinjin approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

Darkren
Darkren approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@Darkren Darkren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Just a small question in there

pkg/visor/config.go Outdated Show resolved Hide resolved
@jdknives jdknives merged commit 3c5f8cd into skycoin:develop Mar 25, 2020
@jdknives jdknives mentioned this pull request Mar 25, 2020
Closed
@nkryuchkov nkryuchkov mentioned this pull request Mar 26, 2020
Merged
@nkryuchkov nkryuchkov deleted the feature/fill-config-defaults branch April 3, 2020 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darkren Darkren Darkren approved these changes

@evanlinjin evanlinjin evanlinjin approved these changes

@jdknives jdknives Awaiting requested review from jdknives

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config migration on binaries update
4 participants
@nkryuchkov @Darkren @evanlinjin @jdknives