Replace unix pipes with TCP sockets #231

Darkren · 2020-03-19T10:13:35Z

Did you run make format && make check?
Yes
Fixes #230

Changes:

Now app module uses TCP sockets instead of unix pipes
Corresponding visor config field was changed
Tests are adapted

pkg/app/appcommon/config.go

…d port)

cmd/skywire-cli/commands/visor/gen-config.go

cmd/skywire-visor/commands/root.go

nkryuchkov

Looks great

Replace unix pipes with TCP sockets

6202fe5

Darkren requested review from evanlinjin and nkryuchkov March 19, 2020 10:13

evanlinjin suggested changes Mar 20, 2020

View reviewed changes

pkg/app/appcommon/config.go Outdated Show resolved Hide resolved

Make server address be passed as a single string (no separate host an…

134c68f

…d port)

nkryuchkov suggested changes Mar 23, 2020

View reviewed changes

cmd/skywire-cli/commands/visor/gen-config.go Outdated Show resolved Hide resolved

cmd/skywire-visor/commands/root.go Outdated Show resolved Hide resolved

Move app server addr to constant

b5629fa

nkryuchkov approved these changes Mar 23, 2020

View reviewed changes

jdknives merged commit 3ba933a into skycoin:develop Mar 23, 2020

jdknives mentioned this pull request Mar 23, 2020

Replace Unix Pipes with TCP sockets #230

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace unix pipes with TCP sockets #231

Replace unix pipes with TCP sockets #231

Darkren commented Mar 19, 2020

nkryuchkov left a comment

Replace unix pipes with TCP sockets #231

Replace unix pipes with TCP sockets #231

Conversation

Darkren commented Mar 19, 2020

nkryuchkov left a comment

Choose a reason for hiding this comment