Merge Milestone 2 #219
Merged
Merge Milestone 2 #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix infinite keep alive loop
…e-mainnet into fix/deregister-tp-#125
Fix: Ensure transports are deregistered and removed when rm-tp is run.
…-mainnet into fix/router-tests
…t into fix/improve-route-group-logging
Improve route group logging, fix route group closing procedure
…t into fix/router-tests
Regarding memory leak. In the `Write` method of the route group we call `writePacketAsync`. It returns `errCh` to us to wait the error from, this channel is not buffered, so `writePacketAsync`'s goroutine actually blocks while trying to pass error to this channel. But `Write` blocks on `select` waiting either error from `errCh` or error from write deadline struct. And if it gets deadline error, it just returns without waiting for any error from `errCh`, making `writePacketAsync` block forever on sending to the channel. And we might have had a lot of such running goroutines
Verify public key before requesting routes
Renamed `loop` to `routegroup` for hypervisor endpoints, function names, struct types and comments.
Remove logging of every packet contents
Fix update endpoint.
Add the manager UI
# Conflicts: # Makefile # README.md # ci_scripts/run-internal-tests.sh # cmd/apps/therealproxy-client/therealproxy-client.go # cmd/skywire-cli/commands/visor/gen-config.go # docker/images/visor/Dockerfile # go.mod # integration/InteractiveEnvironments.md # integration/generic/nodeA.json # integration/generic/nodeC.json # integration/test-proxy.sh # internal/skyenv/const.go # internal/therealproxy/client.go # pkg/hypervisor/hypervisor.go # pkg/hypervisor/hypervisor_test.go # pkg/hypervisor/user_manager.go # pkg/transport-discovery/client/client.go # pkg/transport/manager.go # pkg/transport/manager_test.go # pkg/visor/config.go # pkg/visor/rpc_test.go # pkg/visor/visor.go # pkg/visor/visor_test.go # vendor/github.com/mitchellh/colorstring/LICENSE # vendor/modules.txt
Closed
jdknives
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check? YesPartially fixes #159
Changes:
milestone2andmaster