Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix various issues #1781

Merged
merged 17 commits into from
Mar 21, 2024

Conversation

mrpalide
Copy link
Contributor

Did you run make format && make check? Yes

Fixes #1779 #1769 #1753 #1694

Changes:

  • Fix issues on Windows and Mac installer based on v1.3.20-rc1
  • Fix start and stop issue on proxy/vpn (include ctrl+c command)
  • Fix --timeout flag on start proxy/vpn
  • Fix --http flag to skysocks to serve httpproxy beside socks5

How to test this PR:
You can run visor and trying to start/stop proxy and vpn by these commands:

  • skywire cli proxy start --timeout 30 --http :1010
  • skywire cli vpn start --timeout 20
  • check ctrl+c command during running apps
  • For fixing installers, I'll push v1.3.20-rc2 after merging this PR.

@0pcom
Copy link
Collaborator

0pcom commented Mar 21, 2024

Note there are windows machines of arm64 architecture

@0pcom
Copy link
Collaborator

0pcom commented Mar 21, 2024

$ skywire cli proxy start -k 03419b3c3f9db0404b44afc532a91eb2c108499f7575d0e7937dd8d076d385b607
Starting..............................
Stopped!

seems says it stopped, about the time it was actually started

[2024-03-21T08:28:01.505341862-05:00] DEBUG (STDOUT) [proc:skysocks-client:82e01b3b49514a46857f542a157ad816]: Serving proxy client :1080
[2024-03-21T08:28:01.51240123-05:00] DEBUG (STDOUT) [proc:skysocks-client:82e01b3b49514a46857f542a157ad816]: Serving http proxy :1081

We shouldn't auto-start the http proxy. Especially in instances where I need to test a lot of proxy servers, the http proxy running just takes up another port needlessly

[2024-03-21T08:31:44.569585495-05:00] INFO [visor]: Changing skysocks-client Settings to map["--addr":":1080" "--http":":1081" "--srv":"03894b70efab29edcb5669cda5c34e47a6efce9130849faeaac4c3776e69d7b152" "app":"skysocks-client"]
[2024-03-21T08:31:44.569626939-05:00] INFO [visor:config]: Flushing config to file. config_version="unknown" filepath="/opt/skywire/skywire.json"
[2024-03-21T08:31:44.569965083-05:00] INFO [visor:config]: Flushing config to file. config_version="unknown" filepath="/opt/skywire/skywire.json"
[2024-03-21T08:31:44.570108433-05:00] INFO [visor:config]: Flushing config to file. config_version="unknown" filepath="/opt/skywire/skywire.json"
[2024-03-21T08:31:44.570244989-05:00] INFO [visor:config]: Flushing config to file. config_version="unknown" filepath="/opt/skywire/skywire.json"
[2024-03-21T08:31:44.570396409-05:00] INFO [visor:config]: Flushing config to file. config_version="unknown" filepath="/opt/skywire/skywire.json"

the config seems to be flushed excessively here

@mrpalide
Copy link
Contributor Author

All comments from Moses fixed in last two commits.

@0pcom
Copy link
Collaborator

0pcom commented Mar 21, 2024

please make the timeout 0 by default.

@0pcom 0pcom changed the title Handle sort of issues fix various issues Mar 21, 2024
@0pcom 0pcom merged commit 51093e2 into skycoin:develop Mar 21, 2024
3 checks passed
@mrpalide mrpalide deleted the fix/handle-installer-issues-on-release branch March 26, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants