-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix various issues #1781
fix various issues #1781
Conversation
Note there are windows machines of arm64 architecture |
seems says it stopped, about the time it was actually started
We shouldn't auto-start the http proxy. Especially in instances where I need to test a lot of proxy servers, the http proxy running just takes up another port needlessly
the config seems to be flushed excessively here |
All comments from Moses fixed in last two commits. |
please make the timeout 0 by default. |
Did you run
make format && make check
? YesFixes #1779 #1769 #1753 #1694
Changes:
--timeout
flag on start proxy/vpn--http
flag to skysocks to serve httpproxy beside socks5How to test this PR:
You can run visor and trying to start/stop proxy and vpn by these commands:
skywire cli proxy start --timeout 30 --http :1010
skywire cli vpn start --timeout 20
ctrl+c
command during running appsv1.3.20-rc2
after merging this PR.