Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix VPN issues on CI and Windows #1703

Merged
merged 4 commits into from
Dec 20, 2023
Merged

fix VPN issues on CI and Windows #1703

merged 4 commits into from
Dec 20, 2023

Conversation

mrpalide
Copy link
Contributor

@mrpalide mrpalide commented Dec 19, 2023 •
edited
Loading

Did you run make format && make check? Yes

Fixes:

  • Windows installer false message
  • Windows VPN issue
  • Fix CI e2e-test broken on test VPN

Changes:

  • update product.wxs config for fix Windows installer issue
  • downgrade wireguard/tun lib to v0.0.20230223 for fixing Windows VPN client issue
  • add missing iptables app to install-preq.sh script (check here)

How to test this PR:

  • build windows binaries on windows machine by make build-windows
  • trying to connect to VPN server

@mrpalide mrpalide changed the title [WIP] fix VPN issue on CI and Windows fix VPN issues on CI and Windows Dec 20, 2023
@mrpalide mrpalide marked this pull request as ready for review December 20, 2023 21:36
@0pcom 0pcom self-requested a review December 20, 2023 22:03
0pcom
0pcom approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@0pcom 0pcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@0pcom 0pcom merged commit 24df571 into skycoin:develop Dec 20, 2023
3 checks passed
@mrpalide mrpalide deleted the fix/fix-vpn-issue-on-skywire-services branch March 26, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0pcom 0pcom 0pcom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrpalide @0pcom