Survey collection whitelist #1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comprises minor changes which will enable whitelist-based authentication for the dmsghttp log server, specifically and only implemented for the system survey itself (node-info.json)
these changes reflect those in DMSG PR #219
SurveyWhitelist []cipher.PubKeyarray to config << This needs a corresponding change in the conf service to provide the keys we want to whitelistThe whitelisted keys for survey collection will also always include those keys in the hypervisor field as well as those in the dmsgpty whitelist, so that node operators can also collect the surveys from their visors once they have set either a remote hypervisor or added a key to the dmsgpty whitelist
Note: It is still necessary to add an api endpoint for the
skywire-cli logsurvey & transport log collection to optionally use the visor's public key / existing dmsg client to download the surveys, among other minor changes.