Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several app restarting issues #149

Merged
merged 8 commits into from
Feb 6, 2020
Merged

Fix several app restarting issues #149

merged 8 commits into from
Feb 6, 2020

Conversation

Darkren
Copy link
Contributor

@Darkren Darkren commented Feb 3, 2020

Fixes:

Changes:

  • Improved logging on app restart, change of passcode/PK
  • When changing passcode/PK we now check if the app is down. If it is, it won't start

Now skysocks is being restarted on password change only if it's been running at the moment.
Same goes for skysocks-client and PK change. Logging is changed to cohere with the process
@Darkren Darkren added the bug Something isn't working label Feb 3, 2020
@Darkren
Copy link
Contributor Author

Darkren commented Feb 3, 2020

Now working on #144 , I guess it would be more comfortable to do both issues in a single PR since they're highly related

@Darkren Darkren changed the title [WIP] Fix several app restarting issues Fix several app restarting issues Feb 3, 2020
@Darkren
Copy link
Contributor Author

Darkren commented Feb 3, 2020

Actually this one is done, but I feel like I found one more related bug. Checking now

Copy link
Contributor

@nkryuchkov nkryuchkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

Copy link
Contributor

@Kifen Kifen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

Copy link
Contributor

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Please review my query.

pkg/app/appserver/proc.go Show resolved Hide resolved
@Darkren Darkren merged commit 36e63ac into skycoin:milestone2 Feb 6, 2020
@Darkren Darkren deleted the fix/unconsistent-behavior-while-changing-skysocks-pk branch February 7, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants