Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version command #140

Merged
merged 9 commits into from
Jan 30, 2020
Merged

Version command #140

merged 9 commits into from
Jan 30, 2020

Conversation

nkryuchkov
Copy link
Contributor

Did you run make format && make check?
Yes

Fixes #137

Changes:

  • make build takes version number from git describes and stores it in the compiled binary along with commit hash and build date in RFC3339 format
  • output build info on the start of all binaries except skywire-cli
  • added CLI command for printing build info (skywire-cli node version)
  • return build info in hypervisor endpoint (/nodes/{pk})
  • added a 0.1.0 tag to this repository

How to test this PR:

evanlinjin
evanlinjin approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful work.

Kifen
Kifen approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@Kifen Kifen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@nkryuchkov nkryuchkov merged commit 2f8c64d into skycoin:milestone2 Jan 30, 2020
@nkryuchkov nkryuchkov deleted the feature/version branch March 13, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanlinjin evanlinjin evanlinjin approved these changes

@Kifen Kifen Kifen approved these changes

@Darkren Darkren Awaiting requested review from Darkren

@jdknives jdknives Awaiting requested review from jdknives

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version command
3 participants
@nkryuchkov @evanlinjin @Kifen