Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix control visor apps from hv #1399

Merged
merged 3 commits into from
Oct 25, 2022
Merged

Fix control visor apps from hv #1399

merged 3 commits into from
Oct 25, 2022

Conversation

ersonp
Copy link
Contributor

@ersonp ersonp commented Oct 25, 2022 •
edited
Loading

Did you run make format && make check?

Fixes #1395

Changes:

  • Fixed UI error from log
  • Fixed datarace
  • Fixed visor apps issue

How to test this PR:

  1. Start integration env
  2. Check visor logs with lazydocker
  3. Check if visor apps work from hypervisor UI

@0pcom 0pcom self-requested a review October 25, 2022 19:21
0pcom
0pcom approved these changes Oct 25, 2022
View reviewed changes
Copy link
Collaborator

@0pcom 0pcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@0pcom 0pcom merged commit 863cbbe into skycoin:develop Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0pcom 0pcom 0pcom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ersonp @0pcom