Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/panic and datarace #1394

Merged
merged 3 commits into from
Oct 21, 2022
Merged

Fix/panic and datarace #1394

merged 3 commits into from
Oct 21, 2022

Conversation

ersonp
Copy link
Contributor

@ersonp ersonp commented Oct 20, 2022

Did you run make format && make check?

Fixes #1371

Changes:

  • Made GobDecode nil safe
  • Added logMx to transport
  • Fixed Stcpr() in transport manager

How to test this PR:

  1. Run integration env and check visor logs for datarace
  2. Run ./skywire-cli visor --rpc visor-a:3435 pk to see if panic is fixed

@mrpalide mrpalide merged commit 65e92c0 into skycoin:develop Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrpalide mrpalide mrpalide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ersonp @mrpalide