Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LocalIPs field in model Service #1375

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

ersonp
Copy link
Contributor

@ersonp ersonp commented Sep 28, 2022

Did you run make format && make check?

Fixes #

Changes:

  • Changed datatype of LocalIPs

How to test this PR:

This commit changes the field LocalIPs from []string to a Customized Data Type pq.StringArray.

This fixes the issue while reading to this model whenever there is data in LocalIPs.
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Not sure how that slipped before.

@jdknives jdknives merged commit b60dfcf into skycoin:develop Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants