Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifying SWAddr and Service for Service Discovery PG Migration #1334

Merged
merged 4 commits into from
Aug 11, 2022
Merged

Modifying SWAddr and Service for Service Discovery PG Migration #1334

merged 4 commits into from
Aug 11, 2022

Conversation

mrpalide
Copy link
Contributor

Did you run make format && make check? Yes

Fixes (part of) https://github.com/SkycoinPro/skycoin-service-discovery/pull/105

Changes:

  • add Value and Scan for SWAddr
  • change Service model for use as db model

How to test this PR:

jdknives
jdknives requested changes Aug 11, 2022
View reviewed changes
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine after editing changelog.

@jdknives jdknives merged commit f4ad34d into skycoin:develop Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdknives jdknives jdknives approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrpalide @jdknives