New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve public autoconnect module #1266

Merged

jdknives merged 2 commits into skycoin:develop from mrpalide:fix/public_autoconnect_module

Jun 22, 2022

Contributor

mrpalide commented Jun 22, 2022

Did you run make format && make check? Yes
Fixes #

Changes:

improve public autoconnect module shutting down, switch from simple time.sleep to ticker with cancel context

How to test this PR:

make build
run a visor
close it and see shutting down modules. public autoconnect should be there.

mrpalide added 2 commits

June 22, 2022 14:09


          fix public autoconnect module shutting down

b353e24


          fix module name

fea9a1a

jdknives approved these changes

View reviewed changes

jdknives merged commit 7f62675 into skycoin:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet