Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config gen -x flag #1200

Merged
merged 2 commits into from
May 15, 2022
Merged

Fix config gen -x flag #1200

merged 2 commits into from
May 15, 2022

Conversation

0pcom
Copy link
Collaborator

@0pcom 0pcom commented May 15, 2022

Did you run make format && make check?
yes
Changes:

  • fix retain remote hypervisor configuration; skywie-cli config gen -x flag

How to test this PR:

git clone https://github.com/the-skycoin-project/skywire
cd skywire
git checkout fix-xflag
go run cmd/skywire-cli/skywire-cli.go config gen -r --hvpks 022769f159bb6f67c13140a214d5da0f2192d0881f00449460c458e17eb60115a7
 go run cmd/skywire-cli/skywire-cli.go config gen -rx

the config is successfully regenerated and the remote hypervisor configuration is retained

compare to the current behavior of the rc2 release candidate binaries

@0pcom 0pcom merged commit 0d15c2a into skycoin:develop May 15, 2022
@0pcom 0pcom deleted the fix-xflag branch May 15, 2022 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant