Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Windows Installer #1179

Merged
merged 13 commits into from
May 12, 2022
Merged

Improve Windows Installer #1179

merged 13 commits into from
May 12, 2022

Conversation

mrpalide
Copy link
Contributor

@mrpalide mrpalide commented May 6, 2022

Did you run make format && make check? Yes

Fixes: -

Changes:

  • improve skywire.bat
  • add regenerating config for update skywire
  • store logs for windows installer in C:\Program Files\Skywire\local\logs

How to test this PR:

  • make win-installer, then install new version
  • run by skywire shortcut on start menu or type in cmd/powershell
  • see user message of app in Powershell like this
    image
  • check C:\Program Files\Skywire\local\logs for logs

Note: You can download .msi installer from this link too: https://drive.protonmail.com/urls/Q1S5Y6A8F8#3Sw4ftqrILMC

@mrpalide
Copy link
Contributor Author

Systray on Linux

This PR is related to systray in Windows, but not bad if talk about systray on Linux.
You can download built binnary on current PR for Linux from this link.
This binaries built on EndeavourOS (Archbased).
Gnome is most integrated with systray and work fine without any problem.
XFCE is good, but sometime submenu never appear!
and finally, KDE Plasma is really strange and I can confirm that submenu (means menu of see and select sever for VPN client) not work.

ScreenCast

I thougth should be good if I share screencast of systray functionality on some Linux distos with differente desktops.

Ubuntu

OS: Ubuntu 22.04 (Minimal Installation)
Desktop: Gnome 42.0

ubuntu2204.mp4

Nitrux (Debianbased)

OS: Nitrux 2.1.1
Desktop: KDE Plasma 5.24.4

nitrux.mov

Manjaro (Archbased)

OS: Manjaro 21.2.6
Desktop: XFCE

manjaro.mov

@ersonp
Copy link
Contributor

ersonp commented May 11, 2022

image

getting this error on the .msi installer provided here https://drive.protonmail.com/urls/B2Y8X8TP8C#OZ48LfHXmCJv.

PS D:\Code\go\skywire> make win-installer
Building Systray Windows Binaries...
no Go files in D:\Code\go\skywire\cmd\apps
Build Complete!
Setting go-msi configuration...


    Directory: D:\Code\go\skywire\scripts\win_installer


Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a----         5/11/2022   3:08 PM              0 new.update
Configuration complete!
Building msi...
Rel: can't make D:\Code\go\skywire\scripts\win_installer\build\amd64\skywire-cli.exe relative to C:\Users\Erson\AppData\Local\Temp\go-msi351958395
mv : Cannot find path 'D:\Code\go\skywire\scripts\win_installer\skywire.msi' because it does not exist.
At D:\Code\go\skywire\scripts\win_installer\script.ps1:27 char:1
+ mv skywire.msi ../../skywire.msi
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (D:\Code\go\skyw...ler\skywire.msi:String) [Move-Item], ItemNotFoundException
    + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.MoveItemCommand
 
Build Complete!

This error on the build but I think it is my machine's issue; if I remember correctly I had an issue building previously too.

The logs are working.

return cSummary, nil
return cSummary, nil
}
return nil, nil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we return an error here if there is no procM?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually no need for error. procM just sometimes start/initilaize with delay, and this is just checking for that, also if not start at all then visor not running with this error:

[2022-05-11T14:45:30+04:30] ERROR [visor:startup]: initializing module launcher returning error: lol
[2022-05-11T14:45:30+04:30] ERROR []: Failed to start visor.

@ersonp ersonp merged commit 651e507 into skycoin:develop May 12, 2022
@mrpalide mrpalide deleted the fix/improve-windows-installer branch May 12, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants