-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Windows Installer #1179
Improve Windows Installer #1179
Conversation
Systray on LinuxThis PR is related to systray in Windows, but not bad if talk about systray on Linux. ScreenCastI thougth should be good if I share screencast of systray functionality on some Linux distos with differente desktops. UbuntuOS: Ubuntu 22.04 (Minimal Installation) ubuntu2204.mp4Nitrux (Debianbased)OS: Nitrux 2.1.1 nitrux.movManjaro (Archbased)OS: Manjaro 21.2.6 manjaro.mov |
getting this error on the
This error on the build but I think it is my machine's issue; if I remember correctly I had an issue building previously too. The logs are working. |
return cSummary, nil | ||
return cSummary, nil | ||
} | ||
return nil, nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we return an error here if there is no procM
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually no need for error. procM
just sometimes start/initilaize with delay, and this is just checking for that, also if not start at all then visor not running with this error:
[2022-05-11T14:45:30+04:30] ERROR [visor:startup]: initializing module launcher returning error: lol
[2022-05-11T14:45:30+04:30] ERROR []: Failed to start visor.
Did you run
make format && make check
? YesFixes: -
Changes:
C:\Program Files\Skywire\local\logs
How to test this PR:
make win-installer
, then install new versionC:\Program Files\Skywire\local\logs
for logsNote: You can download
.msi
installer from this link too: https://drive.protonmail.com/urls/Q1S5Y6A8F8#3Sw4ftqrILMC