make exported ParseOptions fileds #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the Parse file by removing the funcs parseV1, ensureAppDisc and the strut ParseOptions because they are not used anymore and we do not write the config to file on startup. Parse_test.go is deleted because it is not needed since we do not write to the config with Parse. Parse now only reads from the io reader provided to ght the conf in V1 and compares the version of the config to the version of the visor and sends back the result in the new variable compat.
This commit removes the parameter from func runApp, runVisor and initConfig as it is no longer used.
ersonp
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check? YesFixes _
Changes:
regexp.MatchStringtostrings.ContainsHow to test this PR:
_