Fix/dmsghttp public ip #1041
Merged
Fix/dmsghttp public ip #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the initilization on the transport module to be before the main module so that the stun module will start as soon as possible.
This commmit changes the verb from %w to %s in t.Errorf().
This commit adds the public IP of the client from the stun module to the request header of services using httpauth.
This commit fixes the nilpointer derefrence by change the data type of clientPublicIP from *string to string.
This commit fixes the module initialization during the visor startup. The Transport module is initialized before the main module as a go routine since InitConcurrent() function blocks until all dependencis are initialized so as to not wait for the stun client to initialize. Also the v.wgStunClient.Add(1) is noved from initStunClient() to NewVisor() to mitigate any issues.
jdknives
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check?yes
Fixes #skywire-services-494
Changes:
authhttpHow to test this PR:
Check #skywire-services-515