Fix dmsghttp datarace #1033
Merged
Fix dmsghttp datarace #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit contains changes to accomodate the changes made to dmsgdirect for solving the datarace. Now the PostEntry() func of the dmsg client no longer adds DelegatedServers to the client entry so we get the servers via AvailableServers() and add them to the client before passing the entry to PostEntry().
jdknives
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check?yes
Fixes #dmsg-137
Changes:
getHTTPClientlogicHow to test this PR:
replace github.com/skycoin/dmsg => ../dmsgingo.modin skywire and runmake depgo build -race -o ./ ./cmd/skywire-visor./skywire-cli config gen -dirtNeeds:
#dmsg-138