-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Argo Events stack with Provider Service component #391
Draft
alexgeorgousis
wants to merge
15
commits into
master
Choose a base branch
from
event-processor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-hazell
force-pushed
the
event-processor
branch
4 times, most recently
from
November 7, 2024 16:06
c6b732b
to
2b3d6a3
Compare
alexgeorgousis
changed the title
Event processor
Replace Argo Events stack with Event Processor component
Nov 7, 2024
alexgeorgousis
changed the title
Replace Argo Events stack with Event Processor component
Replace Argo Events stack with Provider Service component
Nov 7, 2024
alexgeorgousis
force-pushed
the
event-processor
branch
from
November 7, 2024 16:09
2b3d6a3
to
010eb14
Compare
peter-hazell
force-pushed
the
event-processor
branch
from
November 8, 2024 08:56
010eb14
to
fcd4ed7
Compare
Co-Authored-By: Peter Hazell <[email protected]> Co-Authored-By: Alex Georgousis <[email protected]> Co-Authored-By: Toby Pinfold <[email protected]> Co-Authored-By: Ian <[email protected]>
alexgeorgousis
force-pushed
the
event-processor
branch
from
November 8, 2024 10:39
fcd4ed7
to
8aaee21
Compare
alexgeorgousis
force-pushed
the
event-processor
branch
from
November 10, 2024 16:43
61c255c
to
1696eaf
Compare
alexgeorgousis
force-pushed
the
event-processor
branch
from
November 10, 2024 18:01
1696eaf
to
0686d50
Compare
I have a question about the way we've implemented the event processing for providers. Up until this point, the steps to introduce a new provider (I think) were:
What we've basically done in this PR is move the event processing logic for the existing providers to a separate service. So as far as I can tell, the steps are now:
Questions:
|
peter-hazell
force-pushed
the
event-processor
branch
from
November 12, 2024 11:54
853f6e5
to
b533860
Compare
TobyPinfold
force-pushed
the
event-processor
branch
2 times, most recently
from
November 12, 2024 16:21
737c7fc
to
68fa118
Compare
TobyPinfold
force-pushed
the
event-processor
branch
from
November 12, 2024 16:47
3e3c55f
to
f3b6a3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #359
Tasks
argo/providers/vai/eventing_server.go
andargo/providers/vai/provider.go
)EventingServer
interface layer along with CLI layer foreventsource-server
from argo module