Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update build and pipeline #65

Merged
merged 18 commits into from
Jan 11, 2022
Merged

build: update build and pipeline #65

merged 18 commits into from
Jan 11, 2022

Conversation

bcarter97
Copy link
Member

@bcarter97 bcarter97 commented Dec 14, 2021 •
edited
Loading

Description

General housekeeping for the build and pipeline steps of the application in preparation for #48.

Changes

Scala build

  • Update scalafmt from 1.16 to 2.4.3
    • Update config
  • Add scalafix
    • Add organize-imports plugin for scalafix
  • Update ciBuild script to use scalafix
  • Run format/fix on source & test code
  • Move dependencies out of build.sbt to Dependencies.scala
  • Remove bintray resolvers

Pipeline

  • Update Travis Scala version
  • Update cache script
  • Remove unused scala-steward pinned dependencies

Misc

  • Update .gitignore
  • Update License
  • Remove Bintray references from README

@bcarter97 bcarter97 changed the title build: update plugins and build build: update build and pipeline Dec 14, 2021
paulaylingdev
paulaylingdev approved these changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@paulaylingdev paulaylingdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lacarvalho91
lacarvalho91 approved these changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@lacarvalho91 lacarvalho91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor suggestion.

project/Dependencies.scala Outdated Show resolved Hide resolved
project/Dependencies.scala Outdated Show resolved Hide resolved
project/Dependencies.scala Outdated Show resolved Hide resolved
@bcarter97 bcarter97 merged commit 253b06b into master Jan 11, 2022
@bcarter97 bcarter97 deleted the develop branch January 11, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulaylingdev paulaylingdev paulaylingdev approved these changes

@Smudgey Smudgey Smudgey approved these changes

@lacarvalho91 lacarvalho91 lacarvalho91 approved these changes

@serragnoli serragnoli serragnoli approved these changes

@btanyab btanyab Awaiting requested review from btanyab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bcarter97 @serragnoli @lacarvalho91 @Smudgey @paulaylingdev