Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crossbuild for Scala3 #105

Merged
merged 15 commits into from
May 3, 2022
Merged

Crossbuild for Scala3 #105

merged 15 commits into from
May 3, 2022

Conversation

bcarter97
Copy link
Member

@bcarter97 bcarter97 commented Apr 9, 2022

Description

Cross build for Scala 3.

A continuation of this stale branch: https://github.com/sky-uk/kafka-topic-loader/tree/scala-3

Change notes

  • A separate scalaFix config is required, as scalaFix doesn't support Scala3 for some rules yet (RemoveUnused, ProcedureSyntax). In order to still utilise these rules in the Scala 2.x versions, we have a separate config for scala 3 without these rules.
  • Implicits require types

@bcarter97 bcarter97 marked this pull request as ready for review April 10, 2022 00:49
@bcarter97 bcarter97 force-pushed the update/scala-3.1.1 branch 3 times, most recently from 40b1916 to 077acd1 Compare April 28, 2022 20:45
Copy link
Contributor

@paulaylingdev paulaylingdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor comments but looks great, thank you!

build.sbt Show resolved Hide resolved
build.sbt Show resolved Hide resolved
@bcarter97 bcarter97 requested a review from paulaylingdev April 29, 2022 18:32
Copy link
Contributor

@paulaylingdev paulaylingdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other unrelated thing but LGTM

.travis.yml Show resolved Hide resolved
@bcarter97 bcarter97 force-pushed the update/scala-3.1.1 branch from 44a8872 to 3a86adc Compare May 3, 2022 08:49
@bcarter97 bcarter97 enabled auto-merge (squash) May 3, 2022 08:49
@bcarter97 bcarter97 merged commit 3e14133 into master May 3, 2022
@bcarter97 bcarter97 deleted the update/scala-3.1.1 branch May 3, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants