Fix ec2_vol volume_size parameter #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dseeley-sky
approved these changes
Mar 10, 2021
dseeley
pushed a commit
to dseeley/clusterverse
that referenced
this pull request
Mar 16, 2021
* master: Fix ec2_vol volume_size parameter (sky-uk#86)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In newer Ansible versions (i.e. 2.10.6) the ec2_vol module does not accept an empty volume_size var if attaching an existing volume. Volume_size param should not exist in this case. This issue has been observed while redeploying (scheme _scheme_rmvm_keepdisk_rollback):
TASK [create/aws | Attach (or create) volumes where 'src' is present (e.g. inserted as part of _scheme_rmvm_keepdisk_rollback scheme)]
fatal: [localhost]: FAILED! => changed=false
msg: 'argument volume_size is of type <class ''str''> and we were unable to convert to int: <class ''str''> cannot be converted to an int'
The change has been successfully tested in creation (cluster.yml) and redeploy (redeploy.yml) playbooks.