Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the logic that writes the dynamic inventory to file #71

Merged
merged 3 commits into from
Oct 2, 2020
Merged

Fix the logic that writes the dynamic inventory to file #71

merged 3 commits into from
Oct 2, 2020

Conversation

dseeley-sky
Copy link
Contributor

  • Jinja2 in Ansible is set to always delete whitespace before and after the expression, so the lines of inventory are concatenated. Fix the logic, by adding a "{{''}}" to the end of the jinja2 expression.
  • Simplify the EXAMPLE/cluster.yml to remove the anchors and aliases (& and *), which add no value here as they have to be duplicated instead of the tags they're referencing.

@dseeley-sky
Fix the logic that writes the dynamic inventory
781cf22 
+ Jinja2 in Ansible is set to always delete whitespace before and after the expression, so the lines of inventory are concatenated. Fix the logic, by adding a "{{''}}" to the end of the jinja2 expression.
+ Simplify the EXAMPLE/cluster.yml to remove the anchors and aliases (& and *), which add no value here as they have to be duplicated instead of the tags they're referencing.
@dseeley-sky
Remove the default redeploy_scheme. Users should have to specify expl…
18a3d04 
…icitly as it can be destructive.
@dseeley-sky
Update example ami image versions to latest.
60e9b45
@antoineserrano antoineserrano self-requested a review October 2, 2020 10:27
antoineserrano
antoineserrano approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@antoineserrano antoineserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - tested successfully.

@antoineserrano antoineserrano merged commit 653462f into master Oct 2, 2020
dseeley pushed a commit to dseeley/clusterverse that referenced this pull request Oct 5, 2020
@dseeley-sky @dseeley
[FIX] Fix the logic that writes the dynamic inventory to file (sky-uk#71
81e8f2e 
)
@dseeley-sky dseeley-sky deleted the dse09_fix_inventory_writer branch November 4, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoineserrano antoineserrano antoineserrano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dseeley-sky @antoineserrano