Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify 'cli_facts.py' to return dict for 'self._cliargs' in order to … #43

Merged
merged 1 commit into from
Mar 18, 2020

Conversation

mikekrasn
Copy link
Contributor

@mikekrasn mikekrasn commented Mar 18, 2020

…fix stdout_callback

Now cli_facts.py callback plugin returns self._cliargs as ImmutableDict. This breaks stdout_callback option.

To test:

Set environment variable export ANSIBLE_STDOUT_CALLBACK=yaml and run a role with any debug task, i.e. - debug: msg="{{ vars }}"

Expected result:

TASK [clusterverse/create : debug] *****************************************************************************************
ok: [localhost] =>
  msg:
    _cloud_type: aws
    _region: eu-west-1
    ansible_check_mode: false
    ansible_connection: local
    ansible_dependent_role_names: []
    ansible_diff_mode: false
    ansible_facts: {}
    ansible_forks: 50

Current result:

TASK [clusterverse/create : debug] *****************************************************************************************
ok: [localhost] =>
  msg: '{''ansible_python_interpreter'': ''/Users/krasnyam/.virtualenvs/py3/bin/python3.7'', ''release_version'': '''', ''redeploy_scheme'': ''_scheme_addnewvm_rmdisk_rollback'', ''prometheus_node_exporter_install'': True, ''prometheus_node_exporter_port'': ''19100'', ''prometheus_node_exporter_version'': ''0.18.1'', ''prometheus_node_exporter_options'': ''--collector.systemd '',....

@dseeley-sky dseeley-sky merged commit 4b2c4ca into master Mar 18, 2020
@dseeley-sky dseeley-sky deleted the fix_stdout_callback branch March 18, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants