Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change gcp_compute_instance_facts to the new module gcp_compute_insta… #2

Merged
merged 1 commit into from
Jan 27, 2020

Conversation

dseeley-sky
Copy link
Contributor

…nce_info. The return list also becomes resources (previously: items). Fixes #1.

…nce_info. The return list also becomes _resources_ (previously: _items_). Fixes #1.
Copy link
Contributor

@antoineserrano antoineserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@dipiazzg dipiazzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoineserrano antoineserrano merged commit 6ccb7bb into master Jan 27, 2020
@dseeley-sky dseeley-sky deleted the dse09_ansible2.9_gce_fix branch January 28, 2020 09:32
dseeley-sky added a commit that referenced this pull request Apr 1, 2020
antoineserrano pushed a commit that referenced this pull request Apr 1, 2020
dseeley-sky pushed a commit that referenced this pull request Sep 1, 2021
* The AWS route53_zone module returns public zones by default.  Specify the region and vpc if we're deploying to a private zone.
* Fix Jenkinsfile_testsuite branch name passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ansible v2.9 gcp_compute_instance_facts has changed
3 participants