Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPDATE] Allow Direction selection and priority config for GCP firewall #134

Merged
merged 4 commits into from
Aug 22, 2023

Conversation

JamalSky
Copy link
Contributor

Allow GCP firewall rules to be built with the direction parameter and the priority config. https://docs.ansible.com/ansible/latest/collections/google/cloud/gcp_compute_firewall_module.html#parameter-direction
This allows us to set EGRESS or INGRESS. Default will be INGRESS.

https://docs.ansible.com/ansible/latest/collections/google/cloud/gcp_compute_firewall_module.html#parameter-priority
This allows us to set priority. Default will be 1000.

Copy link
Collaborator

@dipiazzg dipiazzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dipiazzg dipiazzg merged commit 0c6a4ed into master Aug 22, 2023
@dipiazzg dipiazzg deleted the 962-add-priority-param-gcp branch August 22, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants