[FEATURE] Make ec2 module working in all the regions #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
citrocity
previously approved these changes
Nov 15, 2022
dseeley
reviewed
Nov 15, 2022
|
|
||
| # Some of the regions are not available for aws module boto.ec2. If the region definitely exists, you may need to upgrade boto or extend with endpoints_path | ||
| # Adding the below to ec2 invocation fixes the issue | ||
| aws_endpoint_url: https://ec2.{{region}}.amazonaws.com |
There was a problem hiding this comment.
Suggestion - add it under the cluster_vars heirarchy? i.e. cluster_vars.aws_endpoint_url
There was a problem hiding this comment.
Done in 7e67153, thanks for the suggestion 👍
citrocity
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the regions are not available for aws module boto.ec2. If the region definitely exists, you may need to upgrade boto or extend with endpoints_path
Specifying
ec2_urlintoec2invocation fixes the issue