Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Add ability to ignore deprecated AMI #121

Merged
merged 1 commit into from
Oct 27, 2022
Merged

[FIX] Add ability to ignore deprecated AMI #121

merged 1 commit into from
Oct 27, 2022

Conversation

dipiazzg
Copy link
Contributor

@dipiazzg dipiazzg commented Oct 27, 2022 •
edited
Loading

This is raised to deal with the fact that AWS AMIs have 2 years life, after which, AMIs are not available anymore.

TASK [cluster_hosts : get_cluster_hosts_target/aws | Replace image with the latest AMI found at 'manifest-location'] ***
 'image': AnsibleUndefined

Setting override_deprecated_ami: true allows to have clusters with mix of new and deprecated AMIs.

citrocity
citrocity approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@citrocity citrocity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked with Giuseppe

antoineserrano
antoineserrano approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@antoineserrano antoineserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be merge for now but will be reverted as soon as timelines allow the team maintaining clusterverse to find an alternative/fix. Reminder set on my end :-).

@antoineserrano antoineserrano merged commit b848701 into master Oct 27, 2022
@citrocity citrocity deleted the add-ignore-deprecated-ami-option branch October 27, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamalSky JamalSky JamalSky approved these changes

@antoineserrano antoineserrano antoineserrano approved these changes

@citrocity citrocity citrocity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dipiazzg @citrocity @antoineserrano @JamalSky