[FIX] Handle Route53 rate limit error #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a smart solution @dipiazzg - nice. |
dipiazzg
requested review from
antoineserrano,
sky-amoncadot,
emmett08,
Daniel-Thavapalan,
JamalSky,
citrocity and
daniel-rolls-sky
citrocity
approved these changes
Mar 14, 2022
sky-amoncadot
approved these changes
Mar 14, 2022
antoineserrano
approved these changes
Mar 14, 2022
Closed
dseeley
pushed a commit
to dseeley/clusterverse
that referenced
this pull request
Mar 18, 2022
* upstream/master: [FIX] Handle Route53 rate limit error (sky-uk#113)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion on #111 I'm submitting this PR. This change handles the
Timeout waiting for resource records changes to be applied: Waiter ResourceRecordSetsChanged failed: Rate exceedederrors introducing arescuetask which, in case of failure, resubmits all the records missed at first glance in synchronous fashion.This has been extensively tested with 30+ nodes clusters: