Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Optional IOPS option in aws volume #112

Merged
merged 4 commits into from
Jan 26, 2022
Merged

[FEATURE] Optional IOPS option in aws volume #112

merged 4 commits into from
Jan 26, 2022

Conversation

citrocity
Copy link
Collaborator

@citrocity citrocity commented Jan 24, 2022 •
edited
Loading

  • added option for IOPS for aws volume. Example:
volume_size: 1, encrypted: True, delete_on_termination: true }
          - { device_name: "/dev/sdg", mountpoint: "/media/mysvc", fstype: "ext4", volume_type: "gp2", volume_size: 1, iops: 100, encrypted: True, delete_on_termination: true }

This is optional and can be left out to have default values.

  • Example files updated

  • added assert for aws gp volume types as max iops is 16k

  • tested it on Jenkins

@citrocity citrocity mentioned this pull request Jan 24, 2022
Closed
dipiazzg
dipiazzg previously approved these changes Jan 24, 2022
View reviewed changes
Copy link
Collaborator

@dipiazzg dipiazzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - This is going to be very useful

@citrocity citrocity marked this pull request as draft January 25, 2022 13:54
@citrocity citrocity marked this pull request as ready for review January 25, 2022 16:39
@citrocity citrocity marked this pull request as draft January 25, 2022 16:43
@citrocity citrocity marked this pull request as ready for review January 26, 2022 14:23
flfernandez
flfernandez approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@flfernandez flfernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dipiazzg
dipiazzg approved these changes Jan 26, 2022
View reviewed changes
Copy link
Collaborator

@dipiazzg dipiazzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Daniel-Thavapalan
Daniel-Thavapalan approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@Daniel-Thavapalan Daniel-Thavapalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

antoineserrano
antoineserrano approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@antoineserrano antoineserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @citrocity, super useful!

@antoineserrano antoineserrano merged commit af81bb8 into master Jan 26, 2022
@antoineserrano antoineserrano deleted the issue_107 branch January 26, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daniel-Thavapalan Daniel-Thavapalan Daniel-Thavapalan approved these changes

@dipiazzg dipiazzg dipiazzg approved these changes

@antoineserrano antoineserrano antoineserrano approved these changes

@flfernandez flfernandez flfernandez approved these changes

@sky-amoncadot sky-amoncadot Awaiting requested review from sky-amoncadot

@JamalSky JamalSky Awaiting requested review from JamalSky

@daniel-rolls-sky daniel-rolls-sky Awaiting requested review from daniel-rolls-sky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@citrocity @flfernandez @antoineserrano @dipiazzg @Daniel-Thavapalan